[webkit-reviews] review denied: [Bug 92834] [CSS] Add selectors for multiple fields time input UI. : [Attachment 155716] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 92834: [CSS] Add selectors for multiple fields time input UI.
https://bugs.webkit.org/show_bug.cgi?id=92834

Attachment 155716: Patch 1
https://bugs.webkit.org/attachment.cgi?id=155716&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155716&action=review


> Source/WebCore/ChangeLog:21
> +	   (input::-webkit-datetime-edit-minute-field[disabled]): Added.
> +	   (input::-webkit-datetime-edit-second-field[disabled]): Added.

Would you explain when they are used please? They aren't same as
input[type=time]:disabled? Why they contain only minute and second?

> Source/WebCore/css/html.css:479
> +}

Do we need font-family:monospace?

> Source/WebCore/css/html.css:487
> +    color: GrayText;
> +}
> +
> +input::-webkit-datetime-edit-second-field[disabled] {
> +    color: GrayText;
> +}

Need a special care for Windows. like input[]:disabled in themeWin.css.

> Source/WebCore/css/html.css:538
> +    height: 1.5em;

Need a comment here in addition to ChangeLog.  It is confusing.