[webkit-reviews] review denied: [Bug 91954] [Filesystem] Assertion on $0.webkitEntries while on the input field. : [Attachment 154207] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 19:37:05 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 91954: [Filesystem] Assertion on $0.webkitEntries while on the input field.
https://bugs.webkit.org/show_bug.cgi?id=91954

Attachment 154207: Patch
https://bugs.webkit.org/attachment.cgi?id=154207&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154207&action=review


The code change looks ok.

> LayoutTests/ChangeLog:11
> +	   * fast/forms/file/file-access-entries-expected.txt: Added.
> +	   * fast/forms/file/file-access-entries.html: Added.

This test doesn't work on platforms without ENABLE_FILE_SYSTEM. So I think the
test should be put into fast/filesystem/.


More information about the webkit-reviews mailing list