[webkit-reviews] review denied: [Bug 92667] REGRESSION: flexbox content-size fails to exclude scrollbar : [Attachment 155593] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 15:54:09 PDT 2012


Ojan Vafai <ojan at chromium.org> has denied  review:
Bug 92667: REGRESSION: flexbox content-size fails to exclude scrollbar
https://bugs.webkit.org/show_bug.cgi?id=92667

Attachment 155593: Patch
https://bugs.webkit.org/attachment.cgi?id=155593&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155593&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:394
> +	   return std::max(LayoutUnit(0),
computeLogicalClientHeight(MainOrPreferredSize, style()->logicalHeight()) -
scrollbarLogicalHeight());

Aren't we subtracting out the scrollbar height twice now?


More information about the webkit-reviews mailing list