[webkit-reviews] review granted: [Bug 81332] Cache support for OpenTypeVerticalData : [Attachment 155164] Yet another try to add a new file to Qt build

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Koji Ishii <kojiishi at gmail.com>'s
request for review:
Bug 81332: Cache support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81332

Attachment 155164: Yet another try to add a new file to Qt build
https://bugs.webkit.org/attachment.cgi?id=155164&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155164&action=review


I think this is OK to land.

It's a bit unfortunate that it's a completely separate cache and makes
FontCache.cpp more complex even though it's only going to be used on Windows,
but I don't know of a better place for it.

It would be awesome if you did a follow up patch to switch the whole file to
using OwnPtrs instead of new/delete.

> Source/WebCore/platform/graphics/FontCache.cpp:192
> +    const AtomicString& familyName = passedFamilyName.isEmpty() ||
passedFamilyName[0] != '@' ?

Nit: I would include parentheses around the the ternary condition.