[webkit-reviews] review granted: [Bug 90318] Allow AudioDestination to support local/live audio input : [Attachment 150267] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 90318: Allow AudioDestination to support local/live audio input
https://bugs.webkit.org/show_bug.cgi?id=90318

Attachment 150267: Patch
https://bugs.webkit.org/attachment.cgi?id=150267&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150267&action=review


Looks good overall. Couple of minor bookkeeping questions. r=me

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:326

> +    // FIXME: Add support for local/live audio input.

Is there a bug filed to track this work?

> Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp:158
> +    // FIXME: Add support for local/live audio input.

Same question.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:133
> +    // FIXME: Add support for local/live audio input.

Here too.