[webkit-reviews] review granted: [Bug 92784] nrwt: clean up TestInputs in preparation for cleaning up sharding : [Attachment 155605] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 31 12:52:45 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 92784: nrwt: clean up TestInputs in preparation for cleaning up sharding
https://bugs.webkit.org/show_bug.cgi?id=92784
Attachment 155605: Patch
https://bugs.webkit.org/attachment.cgi?id=155605&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155605&action=review
> Tools/Scripts/webkitpy/layout_tests/models/test_input.py:40
> + self.timeout = timeout # in msecs; should rename this for
consistency
Nit: ms is a SI unit whereas msecs isn't.
More information about the webkit-reviews
mailing list