[webkit-reviews] review granted: [Bug 92781] nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit : [Attachment 155602] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 12:22:06 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 92781: nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
https://bugs.webkit.org/show_bug.cgi?id=92781

Attachment 155602: Patch
https://bugs.webkit.org/attachment.cgi?id=155602&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155602&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:695
> +	   if not self._test_names:

Shouldn't we checking this after subtracting tests_to_skip?


More information about the webkit-reviews mailing list