[webkit-reviews] review denied: [Bug 92557] [V8] TypedArray binding performance improvements : [Attachment 155595] updated patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied  review:
Bug 92557: [V8] TypedArray binding performance improvements
https://bugs.webkit.org/show_bug.cgi?id=92557

Attachment 155595: updated patch
https://bugs.webkit.org/attachment.cgi?id=155595&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155595&action=review


Thanks for the patch. It looks good overall, but r- because of one needed null
check. Also one comment about sharing code.

> Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:142
> +	   RefPtr<ArrayClass> array = ArrayClass::createUninitialized(length);

Even though currently this will never return 0 (Chrome will crash before
failing a call to malloc), please do the same null check as below. Also please
share the error string.

> Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:150
> +	   return args.Holder();

It would be really nice if this block of code weren't duplicated.