[webkit-reviews] review denied: [Bug 92556] TypedArray set method is slow when called with another typed array : [Attachment 155327] patch proposal

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied arno. <arno at renevier.net>'s request
for review:
Bug 92556: TypedArray set method is slow when called with another typed array
https://bugs.webkit.org/show_bug.cgi?id=92556

Attachment 155327: patch proposal
https://bugs.webkit.org/attachment.cgi?id=155327&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155327&action=review


Good performance improvement but needs more cleanup.

> Source/WebCore/bindings/js/JSArrayBufferViewHelper.h:63
> +	   || offset + length < offset) {

Please try to figure out a way to avoid duplicating these security related
checks. For example, if you pushed the majority of this code into the C++ code
instead of doing it in the bindings, you could define an enum return code and
conditionally call setDOMException based on that return code.

> Source/WebCore/bindings/js/JSArrayBufferViewHelper.h:109
> +	   break;

Refactor this so the code isn't duplicated between here and
constructArrayBufferViewWithTypedArrayArgument below. Since this block doesn't
refer to any JSC concepts, you could even put it in the C++ code so it could be
shared between the JSC and V8 bindings.