[webkit-reviews] review granted: [Bug 92398] All ports should support per test switching of pixel testing : [Attachment 155580] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 92398: All ports should support per test switching of pixel testing
https://bugs.webkit.org/show_bug.cgi?id=92398

Attachment 155580: Patch
https://bugs.webkit.org/attachment.cgi?id=155580&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155580&action=review


r+ with the nit that I'd change the delimiter back to ' if we're not going to
use spaces. I assume you'd have no complaints with someone uploading a separate
patch to switch to spaces? Also, fix the .gyp file, please ;).

Tony, are you okay with this?

> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:136
> +		   '../'

you probably need a comma here, else I expect this is messing up the compile
path: you'd get '../<(DEPTH)' :). 

Also, this should probably be '<(tools_dir)/DumpRenderTree' rather than a
relative path.

> Tools/Scripts/old-run-webkit-tests:754
> +	   $suffixPixelTest = ":--pixel-test";

if we're not able to use spaces, it seems like we might as well stay with
single quotes as the delimiter.

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:339
> +	       command += ":" + driver_input.image_hash

as above.