[webkit-reviews] review denied: [Bug 92685] [BlackBerry] Enable CSS Filter Effects : [Attachment 155578] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Joshua Netterfield
<jnetterfield at rim.com>'s request for review:
Bug 92685: [BlackBerry] Enable CSS Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=92685

Attachment 155578: Patch
https://bugs.webkit.org/attachment.cgi?id=155578&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155578&action=review


Looks good, one more iteration needed.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:371
> +    for (int i = 0;i < LayerData::NumberOfCSSFilterShaders; ++i)

Add a space after i = 0;

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:98
> +	   // see the ping-pong note in LayerFilterRenderer::applyActions

Not completely WebKit style comments.

> Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.h:102
> +    void setFilters(const FilterOperations& filters) { m_filters = filters;
m_filtersChanged = 1; setNeedsCommit(); }

Inconsistent use of m_filtersChanged, setting to 1 and false.

> ChangeLog:11
> +	   * Source/cmakeconfig.h.cmake: Acknowldge CSS filter effects

Typo Acknowldge