[webkit-reviews] review denied: [Bug 92709] -webkit-flex-flow does not work with inherit/initial values : [Attachment 155439] Patch

Tue Jul 31 10:04:57 PDT 2012

Tony Chang <tony at chromium.org> has denied dstockwell at chromium.org's request for
review:
Bug 92709: -webkit-flex-flow does not work with inherit/initial values
https://bugs.webkit.org/show_bug.cgi?id=92709

Attachment 155439: Patch
https://bugs.webkit.org/attachment.cgi?id=155439&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155439&action=review

Thanks for the patch!  Just some small nits.

> Source/WebCore/ChangeLog:10
> +	   Test: fast/css/webkit-flex-flow-initial.html

Can you put the test in css3/flexbox?

> LayoutTests/fast/css/webkit-flex-flow-initial.html:1
> +<style>

<!DOCTYPE html> and <html> tag go here.

> LayoutTests/fast/css/webkit-flex-flow-initial.html:15
> +</style>
> +<span id="test1"></span>

Please include some text describing what this test is testing.

> LayoutTests/fast/css/webkit-flex-flow-initial.html:21
> +result.innerText = value1 === value2 ? 'PASS' : 'FAIL ' + value1 + ' !== ' +
value2;

Can you add a check to see that either value1 or value2 are column?  You may
want to use the js-test-pre.js file to get some convenience functions for
testing.