[webkit-reviews] review granted: [Bug 92715] Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*) : [Attachment 155445] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 31 09:15:16 PDT 2012
Adam Barth <abarth at webkit.org> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 92715: Read tag names and attributes from the saved tokens in
HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)
https://bugs.webkit.org/show_bug.cgi?id=92715
Attachment 155445: Patch
https://bugs.webkit.org/attachment.cgi?id=155445&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155445&action=review
> Source/WebCore/html/parser/HTMLConstructionSite.h:116
> - Element* oneBelowTop() const { return m_openElements.oneBelowTop(); }
> + HTMLStackItem* oneBelowTopStackItem() const { return
m_openElements.oneBelowTopStackItem(); }
You can also keep the same name since you're removing the old function. They
types are incompatible, so it's not going to confuse anyone.
More information about the webkit-reviews
mailing list