[webkit-reviews] review denied: [Bug 91617] Web Inspector: count DOM storage cache memory for native snapshot : [Attachment 155544] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91617: Web Inspector: count DOM storage cache memory for native snapshot
https://bugs.webkit.org/show_bug.cgi?id=91617

Attachment 155544: Patch
https://bugs.webkit.org/attachment.cgi?id=155544&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155544&action=review


> Source/WebCore/inspector/InspectorInstrumentation.h:1254
> +inline size_t InspectorInstrumentation::memoryBytesUsedByStorageCache(Page*
page)

InspectorInstrumentation is common place for inspector hooks called from the
rest of WebCore and you shouldn't go though it for the operations that can be
performed in the inspector code solely. In your case you can pass
InspectorDOMStorageAgent to the InspectorMemoryAgent constructor so that it can
be accessed when the memory snapshot is requested.