[webkit-reviews] review granted: [Bug 92687] StyleResolver::canShareStyleWithElement does not need to use getAttribute for classAttr in the non-SVG case : [Attachment 155401] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 31 07:56:07 PDT 2012
Antti Koivisto <koivisto at iki.fi> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 92687: StyleResolver::canShareStyleWithElement does not need to use
getAttribute for classAttr in the non-SVG case
https://bugs.webkit.org/show_bug.cgi?id=92687
Attachment 155401: Patch
https://bugs.webkit.org/attachment.cgi?id=155401&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Seems fine as is. However I suspect SVG elements rarely end up sharing style
anyway. It would be good to collect some statistics. If this is indeed the case
we could just do if (element->isSVGElement()) return false; in the beginning,
simplifying and speeding up the code.
More information about the webkit-reviews
mailing list