[webkit-reviews] review granted: [Bug 92390] Web Inspector: Profiles: cleanup HeapSnapshotReceiver interface : [Attachment 154672] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 06:32:38 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 92390: Web Inspector: Profiles: cleanup HeapSnapshotReceiver interface
https://bugs.webkit.org/show_bug.cgi?id=92390

Attachment 154672: Patch
https://bugs.webkit.org/attachment.cgi?id=154672&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154672&action=review


Is there a chance we have a test for this?

> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:75
> +	   if (this._json)

What's the reason for splitting this into two methods?


More information about the webkit-reviews mailing list