[webkit-reviews] review denied: [Bug 88970] [Form] Multiple fields time input UI : [Attachment 155459] Patch 6

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 88970: [Form] Multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=88970

Attachment 155459: Patch 6
https://bugs.webkit.org/attachment.cgi?id=155459&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155459&action=review


Ok, I agree with the design and the rough structure. Let's split this into
multiple patches like:

1. Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS and touch source files with
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)  (Only DateTimeFormat.h?)
2. WebCore/css/html.css part
3. WebCore/html/shadow/ part
4. WebCore/html/ part
5. RuntimeEnabledFeatures.cpp part

> Source/WebCore/html/shadow/DateTimeFieldElements.h:88
> +class DateTimeNumericFieldElement : public DateTimeFieldElement {

Please make its own source files.  This class is not small.

> Source/WebCore/html/shadow/DateTimeFieldElements.h:136
> +class DateTimeHourFieldElement : public DateTimeNumericFieldElement {

ditto.

> Source/WebCore/html/shadow/DateTimeFieldElements.h:153
> +class DateTimeSymbolicFieldElement : public DateTimeFieldElement {

ditto.