[webkit-reviews] review canceled: [Bug 91528] Web Inspector: Embeddable Web Inspector : [Attachment 155315] Patch

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has canceled Gabriel Peal
<gpeal at google.com>'s request for review:
Bug 91528: Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528

Attachment 155315: Patch
https://bugs.webkit.org/attachment.cgi?id=155315&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155315&action=review


> Source/WebCore/inspector/front-end/InspectorFrontendAPI.js:132
> +    loadTimelineFromURL: function(url) {

style: { needs to be on a line by its own. Also, please annotate.

> Source/WebCore/inspector/front-end/TimelineModel.js:213
> +	   var data = InspectorFrontendHost.loadResourceSynchronously(url);

I think that this should better be async -- timeline logs happen to be huge.
Also, we need some diagnostics shown to the user when loading fails.

> Source/WebCore/inspector/front-end/TimelineModel.js:215
> +	       data = JSON.parse(data);

I think using data for both string representation and parsed object is quite
unfortunate.

> Source/WebCore/inspector/front-end/TimelineModel.js:218
> +	       WebInspector.log(WebInspector.UIString('Failed to load timeline
data with error: %s', e.message));

We prefer double quotes on strings.

> Source/WebCore/inspector/front-end/TimelineModel.js:219
> +	       return;

Redundant

> Source/WebCore/inspector/front-end/inspector.js:417
> +	  
WebInspector.inspectorView.setCurrentPanel(WebInspector.inspectorView.getPanel(
0));

Do we really need this?

> Source/WebCore/inspector/front-end/inspector.js:419
> +	       var callFunction =
window["InspectorFrontendAPI"][WebInspector.queryParamsObject["callAPI"]];

Why not just InspectorFrontendAPI[WebInspector.queryParamsObject["callAPI"]]?