[webkit-reviews] review requested: [Bug 92602] Change Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or HTMLFormControlElement::readOnly : [Attachment 155452] Patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 00:20:17 PDT 2012


yosin at chromium.org has asked  for review:
Bug 92602: Change Element::isReadOnlyFormControl to
Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or
HTMLFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Attachment 155452: Patch 4
https://bugs.webkit.org/attachment.cgi?id=155452&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

= Changes since the last patch =
* Introduce Element::shouldMatchReadOnlySelector, because
!shouldMatchReadWriteSelector isn't equal to read only control.
** We found this by failure of fast/css/square-button-appearance.html. This
test uses "div" element for rendering square button.


More information about the webkit-reviews mailing list