[webkit-reviews] review denied: [Bug 91759] Web Inspector: count RenderStyle objects in the native memory profiler : [Attachment 155282] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91759: Web Inspector: count RenderStyle objects in the native memory
profiler
https://bugs.webkit.org/show_bug.cgi?id=91759

Attachment 155282: Patch
https://bugs.webkit.org/attachment.cgi?id=155282&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155282&action=review


> Source/WebCore/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Please provide a brief description of the patch.

> Source/WebCore/dom/MemoryInstrumentation.h:34
> +#include "DataRef.h"

This way we will include Source/WebCore/rendering/style/DataRef.h into other
parts of WebCore. Can we avoid this?

> Source/WebCore/dom/MemoryInstrumentation.h:35
> +#include <stdio.h>

Revert this.

> Source/WebCore/rendering/style/RenderStyle.cpp:1504
> +	   info.addVector(*m_cachedPseudoStyles);

This call will not add sizeof(Vector). One way to fix this would be adding of a
specialization for Vector* I think it would make sense as I faced similar
problem while instrumenting StylePropertySet.