[webkit-reviews] review denied: [Bug 92200] The elements in Shadow DOM of input should not be modifiable : [Attachment 155433] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 30 21:40:55 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 92200: The elements in Shadow DOM of input should not be modifiable
https://bugs.webkit.org/show_bug.cgi?id=92200
Attachment 155433: Patch
https://bugs.webkit.org/attachment.cgi?id=155433&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155433&action=review
> LayoutTests/fast/forms/input-user-modify.html:42
> + <input id="search" type="search">
> + <input id="file" type="file">
> + <input id="range" type="range">
> + <input id="color" type="color">
> + <input id="number" type="number">
> + <input id="placeholder" type="text" placeholder="something">
> + <input id="speech" type="text" x-webkit-speech>
We need test cases for <button>, <input type=date>, and <video controls> or
<audio controls>.
> LayoutTests/fast/forms/input-user-modify.html:45
> +<pre id="console"></pre>
This is not used.
> LayoutTests/fast/forms/input-user-modify.html:69
> +var successfullyParsed = true;
This is unnecessary.
More information about the webkit-reviews
mailing list