[webkit-reviews] review granted: [Bug 92602] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTextFormControlElement::readOnly : [Attachment 155431] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 92602: Change Element::isReadOnlyFormControl to
shouldMatchReadWriteSelector or HTMLTextFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Attachment 155431: Patch 2
https://bugs.webkit.org/attachment.cgi?id=155431&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155431&action=review


> Source/WebCore/dom/Element.h:353
> +    virtual bool shouldMatchReadWriteSelector() const { return false; }

nit: we had better avoid to add the function body here for a virtual function.
It wastes compile-time resources.