[webkit-reviews] review granted: [Bug 90468] [chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil : [Attachment 154089] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 90468: [chromium] Use WebAnimation and related classes in
GraphicsLayerChromium and AnimTranslationUtil
https://bugs.webkit.org/show_bug.cgi?id=90468

Attachment 154089: Patch
https://bugs.webkit.org/attachment.cgi?id=154089&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154089&action=review


R=me

> Source/Platform/chromium/public/WebAnimation.h:48
> +	   TargetPropertyTransform = 1,

we normally start at 0, is there a specific reason these are different? are
they matching some other enum?

> Source/Platform/chromium/public/WebLayer.h:148
> +    // Returns false if the anim cannot be added.

"anim"->"animation" to be consistent with other comments

> Source/WebCore/WebCore.gypi:6551
> +	       'inspector/front-end/Images/searchPrev.png',

please revert this before landing (and fix your editor to be less overeager)