[webkit-reviews] review granted: [Bug 92693] nrwt: split test-finding code out from manager.py : [Attachment 155402] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 92693: nrwt: split test-finding code out from manager.py
https://bugs.webkit.org/show_bug.cgi?id=92693

Attachment 155402: Patch
https://bugs.webkit.org/attachment.cgi?id=155402&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155402&action=review


r=me provided the naming nits are addressed.

> Tools/Scripts/webkitpy/layout_tests/controllers/finder.py:38
> +class Finder(object):

"Finder" is a very generic name. I would have named this TestsFinder or
TestsEnumerator.

> Tools/Scripts/webkitpy/layout_tests/controllers/finder.py:64
> +    def _read_test_files(self, filenames, test_path_separator):

_read_test_files is obnoxious name for what it does. Maybe _lint_test_files?

> Tools/Scripts/webkitpy/layout_tests/controllers/finder.py:73
> +		       line = test_expectations.strip_comments(line)

Why are we calling a function in test_expectations!?