[webkit-reviews] review granted: [Bug 92679] Structures should be swept after all other objects : [Attachment 155389] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 92679: Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679

Attachment 155389: Patch
https://bugs.webkit.org/attachment.cgi?id=155389&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155389&action=review


> Source/JavaScriptCore/heap/HeapTimer.h:44
> +

Kill it with fire!

> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:74
> +    return !m_blocksToSweep.size() || m_currentBlockToSweepIndex >=
m_blocksToSweep.size();

I can has assert that m_currentBlockToSweepIndex <= m_blocksToSweep.size()