[webkit-reviews] review granted: [Bug 92448] Make QuotesData use a Vector of pairs : [Attachment 155380] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Elliott Sprehn
<esprehn at gmail.com>'s request for review:
Bug 92448: Make QuotesData use a Vector of pairs
https://bugs.webkit.org/show_bug.cgi?id=92448

Attachment 155380: Patch
https://bugs.webkit.org/attachment.cgi?id=155380&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155380&action=review


> Source/WebCore/css/StyleResolver.cpp:3465
> +	   }
> +	   if (primitiveValue) {

You don't early-return above so it should still be an:

else if (primitiveValue) {

> LayoutTests/fast/css-generated-content/close-quote-negative-depth.html:1
> +

Please don't forget a DOCTYPE as we don't want to test quirks mode behavior.

> LayoutTests/fast/css-generated-content/close-quote-negative-depth.html:8
> +<!-- There should be no quotes. -->

Let's dump this in the output along with a description of what you are testing
and potentially the bug number. This would make it easier for maintainer to see
what's expected and if some output is right or wrong.