[webkit-reviews] review granted: [Bug 92527] nrwt: clean up handling of 'expected' stats in the non-default cases : [Attachment 155017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 15:33:56 PDT 2012


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 92527: nrwt: clean up handling of 'expected' stats in the non-default cases
https://bugs.webkit.org/show_bug.cgi?id=92527

Attachment 155017: Patch
https://bugs.webkit.org/attachment.cgi?id=155017&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155017&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:887
> +    def add_skipped_tests(self, tests_to_skip, wontfix=True):

I don't see either of the callers passing in False for wontfix.  Can we drop
this param?


More information about the webkit-reviews mailing list