[webkit-reviews] review denied: [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation : [Attachment 155376] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 91688: [chromium] Add CCScrollbarAnimationController class for compositor
scrollbar animation
https://bugs.webkit.org/show_bug.cgi?id=91688

Attachment 155376: Patch
https://bugs.webkit.org/attachment.cgi?id=155376&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155376&action=review


> Source/WebCore/page/FrameView.cpp:655
> +// On Android (and potentially other platform that supports pinch zoom)
> +// the main frame should always create scrollbars unless hidden explicitly,
> +// as the viewport size can change in the compositor
> +#if OS(ANDROID)
> +    if (m_frame->page()->mainFrame() == m_frame) {
> +	   if (hMode == ScrollbarAuto)
> +	       hMode = ScrollbarAlwaysOn;
> +	   if (vMode == ScrollbarAuto)
> +	       vMode = ScrollbarAlwaysOn;
> +    }
> +#endif

I thought this was going into a separate patch?

> Source/WebCore/rendering/RenderLayer.cpp:2961
> -    if (!isSelfPaintingLayer() && !hasSelfPaintingLayerDescendant())
> +    if (!isSelfPaintingLayer() && !hasSelfPaintingLayerDescendant() &&
!(paintFlags & PaintLayerPaintingOverlayScrollbars))

Where did all these RenderLayer changes come from in this latest patch?