[webkit-reviews] review granted: [Bug 91032] [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer : [Attachment 155368] Rebased

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 14:49:49 PDT 2012


James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 91032: [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=91032

Attachment 155368: Rebased
https://bugs.webkit.org/attachment.cgi?id=155368&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155368&action=review


Awesome!

> Source/WebKit/chromium/src/WebScrollbarLayer.cpp:59
> +    return static_cast<ScrollbarLayerChromium*>(m_private.get());

does "return unwrap<ScrollbarLayerChromium>()" work instead of the
static_cast<>? it's slightly clearer about what it means, IMO


More information about the webkit-reviews mailing list