[webkit-reviews] review granted: [Bug 92671] Add function to calculate the day in year from a date : [Attachment 155349] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 92671: Add function to calculate the day in year from a date
https://bugs.webkit.org/show_bug.cgi?id=92671

Attachment 155349: Patch
https://bugs.webkit.org/attachment.cgi?id=155349&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155349&action=review


> Source/WTF/ChangeLog:9
> +	   dayInYear() makes existing firstDayOfMonth data
> +	   accessible from other files than DateMath too.

Please mention that this change helps fixing the bug 92286.

> Source/WTF/wtf/DateMath.cpp:289
> -static inline int monthToDayInYear(int month, bool isLeapYear)
> +int dayInYear(int year, int month, int day)

Let's keep this function static local for now since it's not used elsewhere at
the moment.