[webkit-reviews] review denied: [Bug 92532] webkit-patch: system keyring is not used to read my password : [Attachment 155337] updated patch with test

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 92532: webkit-patch: system keyring is not used to read my password
https://bugs.webkit.org/show_bug.cgi?id=92532

Attachment 155337: updated patch with test
https://bugs.webkit.org/attachment.cgi?id=155337&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155337&action=review


> Tools/Scripts/webkitpy/common/net/credentials.py:136
> +    def read_credentials(self, User=User):

the host has a user field, so you should be able to just say
self.host.user.prompt(), and then down in your test you can create a
credentials object, pass it a mock host, and override the prompt method. That
should cut down on the scaffolding a fair amount.