[webkit-reviews] review denied: [Bug 92040] Delete text from password does nothing, proposed fix : [Attachment 154286] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Carlos <carloschilazo at gmail.com>'s
request for review:
Bug 92040: Delete text from password does nothing, proposed fix
https://bugs.webkit.org/show_bug.cgi?id=92040

Attachment 154286: Patch
https://bugs.webkit.org/attachment.cgi?id=154286&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154286&action=review


> Source/WebCore/editing/EditorCommand.cpp:1239
> +	   // Special handling for password fields: Webkit bug 92040
> +	   if (frame->selection()->isInPasswordField())
> +	       return frame->selection()->isRange() &&
enabledInEditableText(frame, event, source) &&
frame->selection()->isContentEditable();

We shouldn't be duplicating a code in enabledCut. I think all we need to do is
to call Editor::canDelete() regardless of whether we're in a password field or
not.