[webkit-reviews] review granted: [Bug 92376] Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition : [Attachment 155253] Fix for assertion being hit, test case, v2.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 92376: Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
https://bugs.webkit.org/show_bug.cgi?id=92376

Attachment 155253: Fix for assertion being hit, test case, v2.
https://bugs.webkit.org/attachment.cgi?id=155253&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
This code change seems fine.

In the test, would it be possible to run the test until it crashes while
recording the mouseMoveTo positions, then use the mouse positions to make a
reliable ASSERT?  You could take the minimum number of mouse positions to hit
the ASSERT and create an automated layout test for it.

It would also be OK to run such a layout test on all ports because it should
still pass on all ports.

Hmm, I guess you need a certain font installed.  Does it repro with either
lohit_hi.ttf, lohit_ta.ttf, or MuktiNarrow.ttf from ttf-indic-fonts-core?  We
already use those fonts on Chromium Linux.

This manual test also seems OK.