[webkit-reviews] review denied: [Bug 92624] Add special export macro for string related functions : [Attachment 155241] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 03:31:07 PDT 2012


Hajime Morrita <morrita at google.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 92624: Add special export macro for string related functions
https://bugs.webkit.org/show_bug.cgi?id=92624

Attachment 155241: Patch
https://bugs.webkit.org/attachment.cgi?id=155241&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155241&action=review


r- due to style error. The code direction looks fine to me.

> Source/WTF/wtf/ExportMacros.h:144
> +#if PLATFORM(WIN)

I expect this conditional to be tuned in coming revisions, right?
If so, it's OK for now.


More information about the webkit-reviews mailing list