[webkit-reviews] review denied: [Bug 92602] [CSS] Use shouldMatchReadWriteSelector for :read-write/read-only pseudo class : [Attachment 155224] Patch 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 00:47:37 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 92602: [CSS] Use shouldMatchReadWriteSelector for :read-write/read-only
pseudo class
https://bugs.webkit.org/show_bug.cgi?id=92602

Attachment 155224: Patch 1
https://bugs.webkit.org/attachment.cgi?id=155224&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155224&action=review


> Source/WebCore/dom/Element.h:354
> +    virtual bool shouldMatchReadWriteSelector() const { return false; }

We should replace isReadOnlyFormControl() with shouldMatchReadWriteSelector in
Element.h.
If we have other isReadOnlyFormControl() callsites, we should remove them
before this patch.

> Source/WebCore/html/HTMLInputElement.cpp:1479
> +bool HTMLInputElement::shouldMatchReadWriteSelector() const
> +{
> +    return m_inputType->shouldMatchReadWriteSelector();
> +}

We have no reasons to forward it to InputType::shouldMatchReadWriteSelector()
for now.
This change just wastes the code size and CPU time.


More information about the webkit-reviews mailing list