[webkit-reviews] review denied: [Bug 92607] Make fast/forms/resources/live-pseudo-selectors.css to be succeeded with when applying :read-only/:read-write selectors to all elements : [Attachment 155212] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 29 23:38:15 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 92607: Make fast/forms/resources/live-pseudo-selectors.css to be succeeded
with when applying :read-only/:read-write selectors to all elements
https://bugs.webkit.org/show_bug.cgi?id=92607

Attachment 155212: Patch 2
https://bugs.webkit.org/attachment.cgi?id=155212&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155212&action=review


> LayoutTests/ChangeLog:16
> +	   When we don't do this, select-live-pseudo-selectors.html renders
background
> +	   of select element as background color specified in :read-only
selector
> +	   instead of background color specified in :invalid or :valid.

ok, I understand the intention of this change now.
It was hard to understand the benefit of this change to me. If this change was
made at the same time as the improvement of :read-only/:read-write, the benefit
would be clear.
I don't think we need to commit this prior to the :read-only/:read-write
improvement. You just change it when you needed. This change is small enough.


More information about the webkit-reviews mailing list