[webkit-reviews] review denied: [Bug 92607] Make fast/forms/select-live-pseudo-selectors.html robust : [Attachment 155210] Patch 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 29 22:27:50 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 92607: Make fast/forms/select-live-pseudo-selectors.html robust
https://bugs.webkit.org/show_bug.cgi?id=92607

Attachment 155210: Patch 1
https://bugs.webkit.org/attachment.cgi?id=155210&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155210&action=review


> LayoutTests/ChangeLog:11
> +	     - Restricts :read-only select to input and textarea elements for
> +	       avoiding unexpected CSS attribute changes

I don't understand this paragraph.
- What is 'CSS attribute'? Do you mean CSS property?
- Why applying :read-only to <select> should be avoided.

> LayoutTests/ChangeLog:14
> +	     - Use CSS color attribute for :read-only pseudo selector for
avoiding
> +	       unspecified behavior when both elements matching :read-only and
> +	       :invalid/:valid selectors.

Is it really unspecified?  I guess CSS has deterministic rules for such cases.


More information about the webkit-reviews mailing list