[webkit-reviews] review granted: [Bug 92477] REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK : [Attachment 155170] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 29 11:48:08 PDT 2012


chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 92477: REGRESSION (r123767):
platform/gtk/accessibility/object-with-title.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=92477

Attachment 155170: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=155170&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155170&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2001
> +    if (!helpText().isEmpty() || !title().isEmpty() ||
!accessibilityDescription().isEmpty())

we should update the comments as well to reflect why we're doing this


More information about the webkit-reviews mailing list