[webkit-reviews] review granted: [Bug 92593] In flipped blocks, a point on the top edge of a box is considered outside the box (and vice versa) : [Attachment 155174] When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 92593: In flipped blocks, a point on the top edge of a box is considered
outside the box (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=92593

Attachment 155174: When comparing y coordinates in flipped blocks, make strict
inequalities non-strict and vice versa
https://bugs.webkit.org/attachment.cgi?id=155174&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155174&action=review


> Source/WebCore/rendering/RenderBlock.cpp:4966
> +	       if (pointInLogicalContents.y() < firstRootBoxWithChildrenTop
> +		   || (blocksAreFlipped && pointInLogicalContents.y() ==
firstRootBoxWithChildrenTop)) {

Would be nice to have a helper function to make these tests more readable. A
similar pattern is repeated 5 times in this patch.