[webkit-reviews] review denied: [Bug 92490] [Qt]REGRESSION(r123786): It made 3 fast/animation tests fail : [Attachment 155167] patch for review.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 92490: [Qt]REGRESSION(r123786): It made 3 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490

Attachment 155167: patch for review.
https://bugs.webkit.org/attachment.cgi?id=155167&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155167&action=review


> Source/WebKit2/ChangeLog:8
> +	   Make sure that an actual repaint happens, when
flushPendingLayerChanges
> +	   is exeuted from within forceRepaint. In this case we do not want to
wait
> +	   for the UIProcess.

This looks like a good fix, but is it related to the animation bug?

>
Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:1
07
> +    bool flushPendingLayerChanges(bool forceRepaint = false);

Boolean trap. Please use an enum { ForceRepaint, DontForceRepaint }.