[webkit-reviews] review granted: [Bug 92569] Ignore visibility:hidden elements when computing compositing layer bounds : [Attachment 155136] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 92569: Ignore visibility:hidden elements when computing compositing layer
bounds
https://bugs.webkit.org/show_bug.cgi?id=92569

Attachment 155136: Patch
https://bugs.webkit.org/attachment.cgi?id=155136&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=155136&action=review


> Source/WebCore/rendering/RenderLayer.cpp:4251
> +    // FIXME: should probably just pass 'flags' down to descendants. This is
a defensive change.

“This is a defensive change” is an appropriate comment for the change log. It
doesn’t make much sense to someone reading the code (what is the change?).

> Source/WebCore/rendering/RenderLayer.cpp:4254
> +    CalculateLayerBoundsFlags descendantFlags =
DefaultCalculateLayerBoundsFlags;
> +    if (flags & ExcludeHiddenDescendants)
> +	   descendantFlags |= ExcludeHiddenDescendants;

There are many ways to write this. I’d go for the one-liner
    CalculateLayerBoundsFlags descendantFlags =
DefaultCalculateLayerBoundsFlags | (flags & ExcludeHiddenDescendants);