[webkit-reviews] review granted: [Bug 77605] [Clamp] support in binding generator : [Attachment 155127] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 28 07:13:23 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 77605: [Clamp] support in binding generator
https://bugs.webkit.org/show_bug.cgi?id=77605

Attachment 155127: patch
https://bugs.webkit.org/attachment.cgi?id=155127&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155127&action=review


Looks OK

> Source/WebCore/ChangeLog:14
> +	   * bindings/scripts/CodeGeneratorCPP.pm:
> +	   (SkipFunction): Skips methods with [Clamp] parameters.

Nit: No update in run-bindings-tests results for CPP? (I am not sure but a
couple of lines might be generated even if you skipped it. Please just check
it.)

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2366
> +    if (isnan(objArgsShortNativeValue))
> +	   objArgsShort = 0;
> +    else

Nit: These three lines could be:

    if (!isnan(objArgsShortNativeValue))

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2376
> +    if (isnan(objArgsLongNativeValue))
> +	   objArgsLong = 0;
> +    else

Ditto.


More information about the webkit-reviews mailing list