[webkit-reviews] review granted: [Bug 90269] [GTK] Add a new and reusable enchant-based spellchecker in WebCore : [Attachment 153515] Patch proposal

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 90269: [GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269

Attachment 153515: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=153515&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153515&action=review


> Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp:30
> +static const size_t maximumNumberOfSuggestions = 10;

Since this is only used in one place, feel free to simply move this to right
above where you use it.

> Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp:34
> +    Vector<CString>* dicts = static_cast<Vector<CString>*>(data);

dicts -> dictionaries

> Source/WebCore/platform/text/gtk/TextCheckerEnchant.h:35
> +class TextCheckerEnchant : public RefCounted<TextCheckerEnchant> {
> +public:
> +    static PassRefPtr<TextCheckerEnchant> create() { return adoptRef(new
TextCheckerEnchant); }

This shouldn't be shared so there's no reason to make it RefCounted.

> Source/WebKit/gtk/webkit/webkitspellcheckerenchant.cpp:42
> +    RefPtr<TextCheckerEnchant> textCheckerEnchant;

This can just be TextCheckerEnchant textCheckerEnchant.