[webkit-reviews] review denied: [Bug 77605] [Clamp] support in binding generator : [Attachment 154975] Updated Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 77605: [Clamp] support in binding generator
https://bugs.webkit.org/show_bug.cgi?id=77605

Attachment 154975: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=154975&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154975&action=review


> Source/WebCore/bindings/scripts/test/TestObj.idl:191
> +#if defined(TESTING_V8) || defined(TESTING_JS)

This is a solution to skip ObjC, GObject and CPP for TestObj.idl, but this is
not a solution to skip them for real IDL files. So instead of adding this
defined macro here, please modify CodeGenerator{ObjC,GObject,CPP}.pm so that
they can skip generating code for [Clamp] attributes.

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2355
> +	   objArgsShort = 0.0;

0.0 => 0

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2365
> +	   objArgsLong = 0.0;

0.0 => 0

> Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:1732
> +	   objArgsShort = 0.0;

You need to declare objArgsShort.

0.0 => 0

> Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:1737
> +	   objArgsLong = 0.0;

Ditto.