[webkit-reviews] review denied: [Bug 92323] Plumb vsync-enabled flag up to compositor thread and support disable-vsync : [Attachment 155068] Patch

[bugzilla-daemon at webkit.org]

John Bates <jbates at google.com> has denied  review:
Bug 92323: Plumb vsync-enabled flag up to compositor thread and support
disable-vsync
https://bugs.webkit.org/show_bug.cgi?id=92323

Attachment 155068: Patch
https://bugs.webkit.org/attachment.cgi?id=155068&action=review

------- Additional Comments from John Bates <jbates at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155068&action=review


Added a test for unthrottled behavior.

>> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:69
>> +	// active state, so make one that ticks slowly.
> 
> I don't know what this means - it looks like we post a task whenever the
"active" state changes, so I can't figure out why we need another timer.  Is
this just because the m_timeSource stores the "active" bool?  We could keep
that as a member on CCFrameRateController if we want

Done.