[webkit-reviews] review denied: [Bug 92553] Add ENABLE_CSS_COMPOSITING flag : [Attachment 155073] patch with OOPS removed

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 92553: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Attachment 155073: patch with OOPS removed
https://bugs.webkit.org/attachment.cgi?id=155073&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155073&action=review


It looks like you are missing a bunch of build systems like CMAKE and
GNUmakefile, aren't you? Also, please fill the lines that ask for content
(mainly the lines with OOPS). Something like "Adds compiler flag
CSS_COMPOSITING to build systems to enable CSS blending and compositing. See
spec ...." Only exception is "Reviewed by". Keep them as they are.

> Tools/Scripts/webkitperl/FeatureList.pm:186
> +	 define => "ENABLE_CSS_COMPOSITING", default => 1, value =>
\$cssCompositingSupport },

It should be 0 by default. We did not decide to activate it in trunk builds.