[webkit-reviews] review denied: [Bug 92531] Build fails because of missing header in GregorianDateTime.h : [Attachment 155045] update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 27 14:07:41 PDT 2012


Patrick R. Gansterer <paroga at paroga.com> has denied tuxator at o2.pl's request for
review:
Bug 92531: Build fails because of missing header in GregorianDateTime.h
https://bugs.webkit.org/show_bug.cgi?id=92531

Attachment 155045: update
https://bugs.webkit.org/attachment.cgi?id=155045&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155045&action=review


i'll fix the two issues and land this patch

> Source/WTF/ChangeLog:3
> +	   Build fails because of missing header in GregorianDateTime.h

since this happens only with mingw this should be mentioned here

> Source/WTF/wtf/GregorianDateTime.h:28
>  #include <wtf/text/CString.h>

1) sort order
2) <wtf/text/CString.h> can be replaced with <wtf/Noncopyable.h>


More information about the webkit-reviews mailing list