[webkit-reviews] review denied: [Bug 92538] Add diagnostic logging for plugins-per-page. : [Attachment 155027] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 27 13:44:22 PDT 2012
Anders Carlsson <andersca at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 92538: Add diagnostic logging for plugins-per-page.
https://bugs.webkit.org/show_bug.cgi?id=92538
Attachment 155027: Patch
https://bugs.webkit.org/attachment.cgi?id=155027&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155027&action=review
> Source/WebCore/html/HTMLEmbedElement.cpp:190
> + if (document()->page() &&
document()->page()->settings()->diagnosticLoggingEnabled()) {
> + Page* page = document()->page();
> + ChromeClient* client = page->chrome()->client();
> + client->logDiagnosticMessage(success ?
DiagnosticLoggingKeys::pluginLoadedKey() :
DiagnosticLoggingKeys::pluginLoadingFailedKey(), m_serviceType,
DiagnosticLoggingKeys::noopKey());
> + if (!page->hasSeenAnyPlugin())
> +
client->logDiagnosticMessage(DiagnosticLoggingKeys::pageContainsAtLeastOnePlugi
nKey(), emptyString(), DiagnosticLoggingKeys::noopKey());
> + if (!page->hasSeenPlugin(m_serviceType))
> +
client->logDiagnosticMessage(DiagnosticLoggingKeys::pageContainsPluginKey(),
m_serviceType, DiagnosticLoggingKeys::noopKey());
> + page->sawPlugin(m_serviceType);
> + }
I think this code can be moved into a function in HTMLPluginImageElement and
shared between HTMLEmbedElement and HTMLObjectElement. You also need to do the
same thing now for HTMLAppletElement. You also want to null check page.
More information about the webkit-reviews
mailing list