[webkit-reviews] review granted: [Bug 92327] -webkit-background-clip:text is blurry in WebKit 1 apps when deviceScaleFactor > 1 : [Attachment 155036] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 92327: -webkit-background-clip:text is blurry in WebKit 1 apps when
deviceScaleFactor > 1
https://bugs.webkit.org/show_bug.cgi?id=92327

Attachment 155036: Patch
https://bugs.webkit.org/attachment.cgi?id=155036&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155036&action=review


> Source/WebCore/ChangeLog:37
> +	   Actually use the new parameter in the CG implementation. Use CG API
to get a
> +
> +	   matrix that definitely includes the device scale when that is
required. 

Blank line here.

> Source/WebCore/platform/graphics/GraphicsContext.h:417
> +	   enum IncludeDeviceScale { DefinitelyIncludeDeviceScale,
PossiblyIncludeDeviceScale};

Space before the }

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1425
>      return AffineTransform(CGContextGetCTM(platformContext()));

It seems like this explicit construction of a AffineTransform is unnecessary.

> LayoutTests/fast/hidpi/gradient-with-scaled-ancestor.html:2
> +<div style="-webkit-transform:scale(2); -webkit-transform-origin:top left;">

> +<div
style="height:300px;width:300px;background-image:-webkit-repeating-linear-gradi
ent(top left, red 10%, blue 30%);border:1px solid">

You should fix this test to not show a scrollbar in the image result.