[webkit-reviews] review granted: [Bug 92395] Animated SVGs do not clear previous frame completely in hidpi mode. : [Attachment 154972] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Varun Jain <varunjain at chromium.org>'s
request for review:
Bug 92395: Animated SVGs do not clear previous frame completely in hidpi mode.
https://bugs.webkit.org/show_bug.cgi?id=92395

Attachment 154972: Patch
https://bugs.webkit.org/attachment.cgi?id=154972&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154972&action=review


> Source/WebCore/svg/graphics/SVGImage.cpp:175
> +    if (shouldClear == ClearImageBuffer)
> +	   buffer->context()->clearRect(enclosingIntRect(scaledRect));
> +
>      // Draw SVG on top of ImageBuffer.
>      draw(buffer->context(), enclosingIntRect(scaledRect), rect,
ColorSpaceDeviceRGB, CompositeSourceOver);

It’s a bit inelegant to compute enclosingIntRect(scaledRect) twice.